Happy New Year Everyone!

Happy New 2024 to you all!

happy new year to all

Happy New Year 2024, All [img]https://t.gamesnostalgia.com/screenshots/n/e/new-year-lemmings-91-92/19619.jpg[/img]

Happy 2024 to the whole forum

Happy New Year!

Have a Happy New Year everyone!

[quote name=AMIGASYSTEM post=3443]@AMIGASYSTEM - In fact, it seems that by increasing the window border by 10, instead of growing and advancing outwards, it does so inwards, but only from the left side! I don't know if this is a clue, Amiga OS 3.1 seems to have border 5, whereas OS 3.9 has a much larger border! At the moment it can be solved by correcting all configurations and fixing the border at 5 (even just the left border)[/quote] I'm not sure how the increased border thickness affects other programs but for IconDrop and other icon tools I have an easy workaround. If border thickness > 5 then factor = (thickness / 2) and if factor > 0 then winw += factor. I have to also apply the correction factor to the x-offsets for the display areas to center the icon images. I don't mind using workarounds in the short run but eventually the correct solution should be to identify and fix the issue(s) in Intuition Library. You shouldn't need to change any window themes if it doesn't affect other programs. The newest version of IconDrop will be posted.

In fact, it seems that by increasing the window border by 10, instead of growing and advancing outwards, it does so inwards, but only from the left side! I don't know if this is a clue, Amiga OS 3.1 seems to have border 5, whereas OS 3.9 has a much larger border! At the moment it can be solved by correcting all configurations and fixing the border at 5 (even just the left border)

After doing some further testing with the Ice Theme and those derived from it with window border thickness of 10 I noticed a few things. For whatever reason if the window border has a thickness greater than five there are distortions both vertical and horizontal. This graphics issue seems to be an internal AROS issue maybe with the Window Decoration? In the screenshot you can see the original distorted IconDrop user interface at the top. After I added some correction factors the enhanced IconDrop user interface in on the bottom left. Notice also the bottom button of ScreenGrabber. The Zune user interface is also distorted. I'm not sure why this is happening. For example if my IconDrop window while using Ice Theme with screen font Arial 16 is supposed to be 231 it is actually drawn as 227. So it is 4 pixels short. Something similar happens to window height. It is drawn shorter than it really is. When you query Window width in this case it reports width = 231. This window layout issue that corrupts the graphics for the right side and bottom side may be related to the window theme scroller gadgets on the right and bottom that are drawn wrong.

The new binary will work for everyone - no need to include both.

This new binary should work for everyone? So it is not necessary to include both? Otherwise I would have to make some changes to the install script, etc.

Yes I have tested with both 2.3 and 2.4, the results are the same, the screenshot I did with 2.4 (C lib)

[quote name=AMIGASYSTEM post=3436]@AMIGASYSTEM - Done the test, now it works perfectly with all "your Themes", with the ICE Theme and all the ones I created based on it have a problem on the left side, I think the themes found on Aros archive also have the same problem, on many of them I created my own themes. I need to check what's different Made a screenshot showing the problem, to see it well I used Palette Prefs to lighten the background of the grey GUIs ![/quote] Thanks for testing. Did you test it on AROS One 2.3 and 2.4 (C lib) ? Or just 2.3. I'd like to know if it works with the newest system files for 2.4. I've identified the scaling issue with the Ice and it's derived themes. The issue happens when the window border thickness is more than 5. Such as with the Ice Theme it's actually 10. I'm working on a solution by recalculating all the offsets. The scaling issue is a problem with the IcoDrop display coordinates not a problem with themes.

Done the test, now it works perfectly with all "your Themes", with the ICE Theme and all the ones I created based on it have a problem on the left side, I think the themes found on Aros archive also have the same problem, on many of them I created my own themes. I need to check what's different Made a screenshot showing the problem, to see it well I used Palette Prefs to lighten the background of the grey GUIs !

I'll keep my fingers crossed and test, both on AROS One 2.3 and AROS One 2.4 (C Library) :) The ICE Theme seems to work fine for me, some of my themes are derived from ICE, on which Zune application have you experienced problems

AMIGASYSTEM Here is the newest IconDrop binary and source code. It has the new Erase_Rectangle function. I tested it with several different images and using several different window themes of different sizes as far as height of window titlebar. I also attached some screenshots of IconDrop. This one is a new version 1.02 so if it works well it will replace version 1.01 on AROS Archives. This is the release candidate. I noticed some display issues with the Ice Theme. But IconDrop isn't the only one. Some Zune Applications also have display issues with the Ice Theme. Maybe Ice Theme needs fixed? The WaterColor Cubic Themes and WaterColor Diagonal Themes work fine at Screen Text Sizes 13,15,16. VMWaros4 and OS41 Themes are also working well with IconDrop. Or rather IconDrop works well with these themes.

The bounding rectangles for the Display Areas aka Drop Zones correspond to two other functions called InRectangleLeft & InRectangleRight. The entire window is a Drop Zones. You can do a drag-n-drop anywhere in theory. But how do we distinguish between left and right? How do we know if the user dropped a "normal" image or "selected" image? The InRectangle functions use the x,y mouse coords during the drop operation to calculate if the drop falls inside or outside the bounding box. The border around the Display Areas are only a visual reference for the user to drop files within the correct Drop Zones. Removing the borders of the Display Areas would cause issues with drag-n-drop operations. We don't want that. :) So I came up with a better solution. I was using the Graphics Library function "EraseRectangle" which uses complex coordinates to replace a specified rectangle in the rasterport with colors of the background which essentially erases it. We have to Erase Rectangle before Display Image or there may be artifacts left from the previous image. I wanted to use Display_Blank function to generate a new blank image filled with (255,153,153,153) background color. Then I could draw that in each Display Area before Display Image. It had some issues but it works now. I tested it with several different themes and so far it works great. I realized it needed to be 78x78 instead of the same size as a real image. So I changed the function name to Erase_Rectangle. :P

OK, thanks for the information, there is always something to learn.

AMIGASYSTEM Although removing the two smaller display areas might be an elegant solution to the display issue it isn't that easy. The display areas are both Raised Bevel Boxes that also represent the bounding rectangles of the Drop Zones. We could replace them with simple black boxes but the top or bottom would still get erased. We need to find a better solution for this problem.